[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Kword tables + patches
From:       Carl G Lewis <carll () optushome ! com ! au>
Date:       2003-05-07 10:53:15
[Download RAW message or body]


> Do you want a CVS account, to commit those changes yourself and keep
> working on the code? See
> http://developer.kde.org/documentation/other/developer-faq.html#q8
>
I now have a login as "clewis". What is the procedure for commits? Do you want 
me to make patches available first for review/approval ? 
I will commit the current patches by the weekend.

> > Not all the changes are so easy. m_pageBoundaries is a big hassle because
> > it contains indexes into m_cells, so every bit of code that uses it has
> > to be touched.

Actually I was wrong about this! Sort of. It turns out there are actually two 
different comments that describe m_pageBoundaries differently. In 
kwtableframeset.h, at the declaration of m_pageBoundaries, and in 
kwtableframeset.cc, at KWTableFrameSet::contains(). The first seems to 
correspond to the majority of the code. I suppose contains() must not be 
called. Most of the time, m_pageBoundaries holds indexes into m_rowPositions, 
not m_cells (I think). I will investigate whether contains() is ever called, 
since it seems plainly incorrect.

Anyway this makes the m_cells conversion less work. There may be a bit more 
refactoring before it is done though. I am particularly keen to break up 
recalcRows() into a few methods.

Carl.


_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]