[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: underlining etc.
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2003-01-16 17:59:23
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 04 January 2003 16:44, Tomasz Grobelny wrote:
> As for now text is underlined with a line of width that is independent of font 
> size. For big fonts it doesn't look very well. So I made underline width 1/18 
> of font height.

About this patch:
you added a _double_ to KoTextStringChar. This doubles the size of that struct
(from 12 to 24), which doubles the amount of memory KWord (or KPresenter)
needs for a given text!!!

This is really a bad solution. KoTextStringChar is very critical in terms of memory
(do you really need to store this value in every character?).
I think the width of the underline is something for KoTextFormat.
Which forces to go for a "difference in line widths when different font sizes are
used together" instead of the "calculating an average" solution (does any
other word processor really do it that way?).

Thanks for reverting KoTextStringChar to its original size, this is very important.

- -- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Klarälvdalens Datakonsult AB, Platform-independent software solutions
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2.1 is available - http://download.kde.org/stable/koffice-1.2.1/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+JvL872KcVAmwbhARAiqlAJ9fJm9OCdIunuouQd9iw/WyVC1/UACfSTEt
jPmkCXcnvD830TfKyAnNhWI=
=uigZ
-----END PGP SIGNATURE-----

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]