[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [kspread] integrating KSpreadValue (and some ramblings)
From:       Philipp =?iso-8859-1?q?M=FCller?= <philipp.mueller () gmx ! de>
Date:       2002-10-30 19:13:12
[Download RAW message or body]

Am Mittwoch, 30. Oktober 2002 14:17 schrieb Ariya Hidayat:
> hi all,
>
> I have integrated value (KSpreadValue) into KSpreadCell and also modified
> other related class to work with the new code. 

Thanks.

> * painting problem: seems *all* cells are always painted. I'm not certain
> if this is because of KSpreadValue change (I didn't touch painting code).
> However if this is the case, perhaps Philipp and John can help me locating
> problem.

Haven't tried the code yet, but only John can help here.

> Also, I'd like to know if any other particular problems arised because this
> (rather massive) change.

If I find, I will let you know.

> IMHO layout information (like border,
> color, etc) should be kept in a different class, but it should not be the
> parent class for KSpreadCell like the current situation. The advantage is
> being able to share the data. Since a worksheet likely will have cells with
> many similar layout, this will reduce memory consumption.

Isn't Norbert working on this either?

> Another note, could painting stuff also be written in e.g
> KSpreadCellPainter class ? 
If you think it makes sence, yes we can put it out of KSpreadCell, but I don't 
know what we will really gain beside of better abstraction.

> All information for cell painting is already
> made public in KSpreadCell (AFAIK, CMIIW) so making it in separate class
> should do no harm.

Public should be paintCell only. Borders and Background are called by 
paintCell only.
Or do you mean the other ones like makeLayout or textSize? These are not 
really painting related, as they are used mostly to define position, size and 
lenght of displayed text in zoom independet values (yes, currently not 
completely independent, but should be at the end). These methods maybe part 
of the layout class as well or we should keep them in KspreadCell IMHO.

So it would be the (I think 6) painting methods in KSpreadCell, which is not 
too much code to be needed to seperate.

> Comments ?

This is so something about our coding style. Shall we seperate most and put 
them in different files? We already have a lot of files (and ofcourse code), 
so more files may make it more cluttered.
But I'm not the one who can talk about good coding style. If you or the other 
prefer something, I'm fine with it. 
BTW: Your prefer code the same as I do (spaces, tabs, etc. ;-)

Chears,

Philipp
_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]