[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KSpread: too strict validation on loading
From:       Norbert Andres <nandres () web ! de>
Date:       2002-08-31 14:33:00
[Download RAW message or body]

On Saturday 31 August 2002 03:49, John Dailey wrote:
> I see no problems with the patch, but I'm a bit confused about the purpose.
> Are we going to try to allow forward compatibility with files?
Well this is one reason for XML. You only read thing you understand and ignore 
features you don't have.
Maybe this patch turns out to be useless in the future, but if KSpread 1.2 
user can still read 1.3 documents because of the patch it is nice. Anyway, it 
doesn't hurt if we try to in this case.
Norbert

>
> -John
>
> On Friday 30 August 2002 01:54 pm, Norbert Andres wrote:
> > Hi,
> >
> > while reading kspread_layout code I noticed, that we have very strict
> > rules e.g. for alignX/Y values:
> > if it is not in the range we understand, we just return false.
> >
> > This is very nice if you think about forward compatibility: if we added
> > another Flag, e.g. for aligning across a selection (see
> > Gnumeric/OpenCalc), in KSpread 1.3 this document can't be readed anymore.
> >
> > Using the attached patch it defaults to the standard value if KSpread
> > reads in something it can't understand.
> >
> > Commit?
> > Norbert
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@mail.kde.org
> http://mail.kde.org/mailman/listinfo/koffice-devel

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]