[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Fwd: Re: KSpread DTD
From:       Nicolas Goutte <nicog () snafu ! de>
Date:       2002-08-28 13:04:58
[Download RAW message or body]

I have changed it (see attached patch)

I am closing bug #37601.

Have a nice day/evening/night! 

On Mittwoch, 28. August 2002 09:46, Ariya Hidayat wrote:
> This is WRT to bug #37601 (Errors in KSpread DTD). Nicolas has fixed some,
> but there's still to be done. I don't understand enough about DTD and
> friends, so if anyone feels brave, have a look.
> (Followed some hints, thanks to Nicolas)
>
> ----------  Forwarded Message  ----------
> Subject: Re: KSpread DTD
> Date: Tue, 27 Aug 2002 22:04:36 +0200
> From: Nicolas Goutte <nicog@snafu.de>
> To: Ariya Hidayat <ariya@kde.org>
>
> Has someone corrected the definition of <rect> in the meantime?
>
> As at that time, I had never had a feedback from any KSpread developer, I
>  have done nothing further. Therefore <rect> was still defined two times.
>
> (Later...)
> Well, I have now loked at it. The definition is still not right. And
> someone has modified it without telling when to use some attributes and
> when to use the others.
>
> If you want to correct yourself, from currently:
>
> <!ELEMENT rect  EMPTY>
> <!ATTLIST rect  left-rect      CDATA #IMPLIED
>                 right-rect     CDATA #IMPLIED
>                 bottom-rect    CDATA #IMPLIED
>                 top-rect       CDATA #IMPLIED>
> <!ATTLIST rect  x              CDATA #REQUIRED
>                 y              CDATA #REQUIRED
>                 w              CDATA #REQUIRED
>                 h              CDATA #REQUIRED>
>
> you should have something like:
>
> <!ELEMENT rect  EMPTY>
> <!ATTLIST rect  left-rect      CDATA #IMPLIED
>                 right-rect     CDATA #IMPLIED
>                 bottom-rect    CDATA #IMPLIED
>                 top-rect       CDATA #IMPLIED
>                 x              CDATA #IMPLIED
>                 y              CDATA #IMPLIED
>                 w              CDATA #IMPLIED
>                 h              CDATA #IMPLIED>
>
> Then you just have to document when to use which attributes.
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@mail.kde.org
> http://mail.kde.org/mailman/listinfo/koffice-devel

["kspread_dtd.patch" (text/x-diff)]

Index: kspread.dtd
===================================================================
RCS file: /home/kde/koffice/kspread/dtd/kspread.dtd,v
retrieving revision 1.30
diff -u -b -r1.30 kspread.dtd
--- kspread.dtd	2002/06/24 18:56:36	1.30
+++ kspread.dtd	2002/08/28 13:02:10
@@ -147,23 +147,35 @@
 
 <!ELEMENT refname (#PCDATA)>
 
-<!--	Describe the area selected.
+<!--
+	They are two conflicting uses of <rect>
+
+ Use 1:
+    Describe the area selected.
         Attributes:
 
          left-rect   value of the left border
          right-rect  value of the right border
          bottom-rect value of the bottom border
          top-rect    value of the top border
+
+ Use 2:
+    Use unknown (### TODO)
+        Attributes:
+         x          x position
+         y          y posution
+         w          width
+         h          height
 -->
 <!ELEMENT rect  EMPTY>
 <!ATTLIST rect  left-rect      CDATA #IMPLIED
                 right-rect     CDATA #IMPLIED
                 bottom-rect    CDATA #IMPLIED
-                top-rect       CDATA #IMPLIED>
-<!ATTLIST rect  x              CDATA #REQUIRED
-                y              CDATA #REQUIRED
-                w              CDATA #REQUIRED
-                h              CDATA #REQUIRED>
+                top-rect       CDATA #IMPLIED
+                x              CDATA #IMPLIED
+                y              CDATA #IMPLIED
+                w              CDATA #IMPLIED
+                h              CDATA #IMPLIED>
 
 <!--	Contains the table data for the various tables.
 

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]