[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KSpread bug #46941
From:       John Dailey <dailey () vt ! edu>
Date:       2002-08-26 5:58:04
[Download RAW message or body]

I agree.  Does this patch seem reasonable?

-John
On Sunday 25 August 2002 04:40 pm, Norbert Andres wrote:
> Bug description below...
>
> Hi,
>
> my fix would be to change the line 523 of kspread_canvas.cc to
> that:
>     if (m_bChoose)
>     {
>       updateChooseRect(topLeft, topLeft); 	<=
>     }
>
> Easy fix, but it seems to work and selecting cells when for a dialog works
> better now, too.
>
> If we use this as a fix we can also clean up a few things in this methods,
> since some calculations are not need anymore.
>
> Norbert
>
>
> ****
>
> Hi!
> enter a big value in Call A1, so it extends over into B1
> go to A2
> Enter "=+<KeyUP><Enter>"
> the result for A2 is "=+A1:B1" and gives a parse error
> cu
> ferdinand
>
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@mail.kde.org
> http://mail.kde.org/mailman/listinfo/koffice-devel

["canvas_patch" (text/x-diff)]

Index: kspread_canvas.cc
===================================================================
RCS file: /home/kde/koffice/kspread/kspread_canvas.cc,v
retrieving revision 1.311
diff -p -u -3 -r1.311 kspread_canvas.cc
--- kspread_canvas.cc	2002/08/20 02:18:35	1.311
+++ kspread_canvas.cc	2002/08/26 05:56:39
@@ -500,22 +500,17 @@ void KSpreadCanvas::gotoLocation( QPoint
   }
   else
   {
-    QRect newSelection;
     QPoint topLeft(location);
-    QPoint bottomRight;
     KSpreadCell* cell = table->cellAt(location);
     if ( cell->isObscured() && cell->isObscuringForced() )
     {
       cell = cell->obscuringCells().first();
       topLeft = QPoint(cell->column(), cell->row());
     }
-    bottomRight.setX(topLeft.x() + cell->extraXCells());
-    bottomRight.setY(topLeft.y() + cell->extraYCells());
-    newSelection = QRect(topLeft, bottomRight);
 
     if (m_bChoose)
     {
-      updateChooseRect(bottomRight, topLeft);
+      updateChooseRect(topLeft, topLeft);
     }
     else
     {

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]