[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: question about freeze and patch
From:       Norbert Andres <nandres () web ! de>
Date:       2002-04-12 5:24:10
[Download RAW message or body]

With this patch you copy the formula not the result, don't you?

But I don't think, that's what anybody want so I changed it to always copy the 
result.
If you have a table like

	A	B
1	2	4
2	=A1+B1

The user wants
2	4
6
to be inserted in e.g. KMail. And not the formula which wouldn't be really 
useful in this case. (That's at least what I think)

I would apply this instead: (to fix the spaces between columns in text mode)

Index: kspread_table.cc
===================================================================
RCS file: /home/kde/koffice/kspread/kspread_table.cc,v
retrieving revision 1.337
diff -u -r1.337 kspread_table.cc
--- kspread_table.cc    2002/04/11 20:11:45     1.337
+++ kspread_table.cc    2002/04/12 05:17:52
@@ -3963,6 +3963,8 @@
       }
     }

+    ++max;
+
     for (y = m_rctSelection.top(); y <= m_rctSelection.bottom(); ++y)
     {
       for (x = m_rctSelection.left(); x <= m_rctSelection.right(); ++x)
@@ -3971,8 +3973,9 @@
         if( !cell->isDefault() )
         {
             int l = max - cell->strOutText().length();
-            for ( int i = 0; i < l; ++i )
-              result += " ";
+            if (x > m_rctSelection.left())
+                for ( int i = 0; i < l; ++i )
+                  result += " ";
             result += cell->strOutText();
         }
         else


Regards
Norbert

On Friday 12 April 2002 01:39, John Dailey wrote:
> According to the release schedule, as of today "KOffice is temporarily
> frozen".  Does this mean we need to post patches on this list?  Or do we
> still commit at will, but only bugfixing patches?
>
> Just in case, here's a patch to fix bug 40465 (Copy as text doesn't work if
> more than one cell is selected).
>
> -John

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]