[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KSpread
From:       John Dailey <dailey () vt ! edu>
Date:       2002-03-01 3:27:40
[Download RAW message or body]

Since the maximum row or column number is 2^15, why don't we make either 
KSPREAD_CLUSTER_LEVEL_1 or 2 128 instead of 256.  I don't guess it matters 
which one.

Also, the memory overhead for the cell cluster jumps from just under 40K to 
128K.  I don't see this as a problem but maybe others do?

-John

On Thursday 28 February 2002 06:21 pm, Philipp Müller wrote:
> Following patch adresses 2 issues:
>
> 1. Row limitation:
> Rows were limited by 10000 lines (see also BR 11819):
>
> I don't know if all the changes were realy necessary, but from my point all
> are obvious:
> file kspread_canvas.cc: Limitation should be more than 9999 lines/columns
>
> file kspread_cluster.h: This is the main reason for the limitation.
>
> file kspread/kspread_layout.cc: Again a limitation by 10000
>
> file kspread_table.cc: Don't know if this part is necessary, but I think
> int=0x10000 is wrong, it should be maximum int=0xFFFF.
> But this should be left to one, that knows the difference better.
> Even in the worst case 0x8000 should already be the end.
>
> 2. Limitation of column labels:
> file: kspread_util.cc
> I already sent this to the koffice mailing list and still think, that this
> single part doesn't have an logical influence on the other part of the
> code. Again this patch makes only possible that this routine can generate
> senseful text labels for values > 26*26. It can now generate texts for
> values up to 2^16 values, even if it is limited by code to 2^15.
>
> Please apply.
>
> Philipp

_______________________________________________
koffice-devel mailing list
koffice-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]