[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: A few more issues with KWord...
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-06-22 20:52:40
[Download RAW message or body]

On Friday 22 June 2001 23:15, Chris Howells wrote:
> David Faure wrote:
> 
> 
> > I fixed a killu crash now, so it might even work with the killu objects ;-)
> 
> OK, great work -- it's very nearly fixed :)
> 
> With the attached document I still can't get the first bit of the bottom 
> line of the footer all into size eight (e.g. the path).
> 
> Even after formatting, saving, closing, opening, etc, it still appears 
> as in footer.png (attached)...
> 
> I can reproduce this in testcase.kwd (attached).

Me too... will investigate (seems to be part of a bigger bug with the
format collection). If you're in a hurry, just tar it open, and add
<SIZE value="8" />  below <FORMAT id="4" pos="0" len="1" >.
Aren't open file formats great ? ;-)

> About the Kllustrator bug -- I can't make it crash now (excellent :) ), 
> so can we make a diff against beta3 with the fix, so that it can be put 
> on koffice.org under the "Release Notes" section (like we did with the 
> KWord one against beta2 IIRC)?
> 
> If you send me the diff, I'll stick it on there...
> 
> I think it is rather a critical fix :)

Right. There you go.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today


["diff" (text/x-c)]

Index: GDocument.cc
===================================================================
RCS file: /home/kde/koffice/killustrator/GDocument.cc,v
retrieving revision 1.94
retrieving revision 1.95
diff -u -p -r1.94 -r1.95
--- GDocument.cc	2001/06/16 08:24:16	1.94
+++ GDocument.cc	2001/06/22 13:45:47	1.95
@@ -1,6 +1,6 @@
 /* -*- C++ -*-
 
-  $Id: GDocument.cc,v 1.94 2001/06/16 08:24:16 mlaurent Exp $
+  $Id: GDocument.cc,v 1.95 2001/06/22 13:45:47 faure Exp $
 
   This file is part of KIllustrator.
   Copyright (C) 1998-99 Kai-Uwe Sattler (kus@iti.cs.uni-magdeburg.de)
@@ -163,7 +163,7 @@ void GDocument::movePage( int from, int 
 
   if ( to > static_cast<int>(pages.count()) )
   {
-   kdDebug(0) << "?" <<endl;
+   kdDebug(38000) << "?" <<endl;
   }
   else
   {
@@ -205,7 +205,8 @@ void GDocument::setAutoUpdate (bool flag
   if (autoUpdate)
   {
     selBoxIsValid = false;
-    activePage()->updateHandle ();
+    assert( active_page );
+    active_page->updateHandle ();
     emit changed ();
   }
 }
@@ -303,18 +304,23 @@ bool GDocument::readFromXml (const  QDom
     }
 
     pages.clear ();
+    active_page = 0;
     QDomNode n = killustrator.firstChild();
     while(!n.isNull())
     {
       QDomElement pe=n.toElement();
-      kdDebug(0) << "Tag=" << pe.tagName() << endl;
+      kdDebug(38000) << "Tag=" << pe.tagName() << endl;
       if (pe.tagName() == "page")
       {
         GPage *page = addPage();
+        if ( !active_page )
+            active_page = page;
         page->readFromXml(pe);
       }
       n=n.nextSibling();
     }
+    if ( !active_page )
+        kdWarning(38000) << "No page found !" << endl;
 
     setModified (false);
     emit gridChanged ();
@@ -345,10 +351,9 @@ bool GDocument::readFromXml (const  QDom
 
     pages.clear ();
 
-    GPage *page = addPage();
-    page->readFromXmlV2(killustrator);
-
-    page->setName(i18n("Page %1").arg(1));
+    active_page = addPage();
+    active_page->readFromXmlV2(killustrator);
+    active_page->setName(i18n("Page %1").arg(1));
     curPageNum = 2;
 
     setModified (false);


[prev in list] [next in list] [prev in thread] [next in thread]