[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: An internationalization patch of KSpread and KChart
From:       Toshitaka Fujioka <tositaka () soft ! kusa ! ac ! jp>
Date:       2000-11-30 5:28:09
[Download RAW message or body]

Hello.

David Faure wrote:

> 
> ----------------------------------------
> Content-Type: application/gzip; charset="ISO-2022-JP"; name="koffice-2.0-kspread-i18n-20001126.diff.gz"
> Content-Transfer-Encoding: base64
> Content-Description: 
> ----------------------------------------
> 
> -    double money = locale()->readMoney(m_strText, &m_bValue);
> +    double money = locale()->readMoney(m_strText.utf8(), &m_bValue);
> Why this, for instance ?? ReadMoney takes a QString, why send utf8 to it ??
> 

I'm very sorry.

This problem was a bug by toDouble( bool *ok ) of qt-2.2.2.

Therefore, please do not mind,
=============================================================
@@ -3539,10 +3539,12 @@
      m_bValue = TRUE;

      // First try to understand the number using the locale
-    double value = locale()->readNumber(p, &m_bValue);
+    double value = locale()->readNumber(p.utf8(), &m_bValue);
      // If not, try with the '.' as decimal separator
-    if (!m_bValue)
+    if (!m_bValue) {
          value = p.toDouble(&m_bValue);
+        m_bValue = FALSE;
+    }

      if ( m_bValue )
      {
@@ -3619,7 +3621,7 @@
                  }
          }
          */
-    double money = locale()->readMoney(m_strText, &m_bValue);
+    double money = locale()->readMoney(m_strText.utf8(), &m_bValue);
      if (m_bValue)
      {
          m_dValue=money;

=====================================================================
.

May I ask a favor of you?

Because there are various patches for KDE and Qt in this page
( http://www.kde.gr.jp/patch/ ) , please watch once.
There is a simple commentary of English about each patch.

Bye.





> I'm not much in favour of this patch as it is, it looks quite untested to me.
> 
> Parts of it look right, though (removing local8Bit from kdDebug calls, removing
> .latin1() in places where a QString is expected, the XIM line, etc.)
> Laurent, can you have a look and integrate those ?
> 
> ----------------------------------------
> Content-Type: text/plain; charset="ISO-2022-JP"; name="koffice-2.0-kchart-i18n-20001105.diff"
> Content-Transfer-Encoding: base64
> Content-Description: 
> ----------------------------------------
> 
> kchart has already been extensively i18n-fixed in CVS.
> If you could test the HEAD branch and confirm it works, I could backport
> the changes to the branch for the 2.0.1 release.
> Thanks.

[prev in list] [next in list] [prev in thread] [next in thread]