[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: KSBarIcon
From:       Kurt Granroth <granroth () kde ! org>
Date:       2000-05-30 6:49:45
[Download RAW message or body]

Simon Hausmann wrote:
> > My guess is that the actions are somehow getting the wrong instance to
> > use for loading the icons.  Now Simon fixed up the instance related
> > stuff in kaction and I thought that fixed everything but I was wrong.
> 
> The reason for this is what we discussed on irc recently :-)

Yeah, we did.. and I totally forgot about that!  I am getting
forgetful in my old age, it seems :-(

> As we already discussed on IRC I believe the right solution is to let
> KToolBarButton know about the right KInstance. This sounds a bit like
> overhead (each toolbarbutton holding a pointer to the right KInstance),
> but I see now other way. If we just let KToolBar know about a KInstance,
> then this will break as soon as two components with different instances
> insert buttons into the same toolbar.
> 
> It seems just adding a KInstance *instance = 0L; as last argument for the
> insertButton method should do it (from the KToolBar API's POV) . Should be
> source compatible (if instance == 0 -> use KGlobal::instance() ).
 
Yep, quite right.  I'll do that and commit on Wednesday.
-- 
Kurt Granroth            | http://www.granroth.org
KDE Developer/Evangelist | SuSE Labs Open Source Developer
granroth@kde.org         | granroth@suse.com
           KDE -- Putting a Friendly Face on Unix

[prev in list] [next in list] [prev in thread] [next in thread]