[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: kspread does not load column size changes
From:       "Byron C. Servies" <bservies () pacang ! com>
Date:       1999-12-24 1:49:02
[Download RAW message or body]

Macintosh, actually.  Here is a version saved with unix line breaks (LF).  And,
just in case, the cut-and-paste version is below.

Byron

On 12/24/1999 at 1:37 AM, faure@kde.org (David Faure) wrote:

> This sounds very good - but the patch is in some sort of
> DOS mode (with ^M chars) and I can't get it right - even using dos2unix
> (which removes all CRs)...
> 
> If you can make it a normal unix text file, I'd be grateful :-)
> 
> PS : I'm leaving tomorrow - somebody else should apply it
> if I don't have the time for it.
> 
> On Thu, Dec 23, 1999 at 01:16:22PM -0800, Byron C. Servies wrote:
> > Hi there!
> > 
> > kspread has not been reloading changes to column widths for me in
> > the past several weeks.  I had some time this morning, and a (very)
> > little investigation showed that it was saving the information, but
> > was using the attribute name "col", while the KSpreadTable::loadXML
> > routine was looking for the attribute name "column".
> > 
> > Since "column" is listed in the DTD, I changed kspread_layout.cc to
> > use "column" instead of "col" and seem to have corrected the
> > problem.
> > 
> > Context diff attached from cvsup of yesterday (12/22).
> > 
> > Byron

*** kspread_layout.cc.orig      Thu Dec 23 13:03:52 1999
--- kspread_layout.cc   Thu Dec 23 13:04:12 1999
***************
*** 247,255 ****
  
  QDomElement ColumnLayout::save( QDomDocument& doc )
  {
!   QDomElement col = doc.createElement( "col" );
    col.setAttribute( "width", m_fWidth );
!   col.setAttribute( "col", m_iColumn );
  
    return col;
  }
--- 247,255 ----
  
  QDomElement ColumnLayout::save( QDomDocument& doc )
  {
!   QDomElement col = doc.createElement( "column" );
    col.setAttribute( "width", m_fWidth );
!   col.setAttribute( "column", m_iColumn );
  
    return col;
  }
***************
*** 263,269 ****
      if ( !ok ) return false;
    }
  
!   m_iColumn = col.attribute( "col" ).toInt( &ok );
    if ( !ok ) return false;
  
    // Validation
--- 263,269 ----
      if ( !ok ) return false;
    }
  
!   m_iColumn = col.attribute( "column" ).toInt( &ok );
    if ( !ok ) return false;
  
    // Validation


["kspread_layout.cc.patch" (application/octet-stream)]

*** kspread_layout.cc.orig	Thu Dec 23 13:03:52 1999
--- kspread_layout.cc	Thu Dec 23 13:04:12 1999
***************
*** 247,255 ****
  
  QDomElement ColumnLayout::save( QDomDocument& doc )
  {
!   QDomElement col = doc.createElement( "col" );
    col.setAttribute( "width", m_fWidth );
!   col.setAttribute( "col", m_iColumn );
  
    return col;
  }
--- 247,255 ----
  
  QDomElement ColumnLayout::save( QDomDocument& doc )
  {
!   QDomElement col = doc.createElement( "column" );
    col.setAttribute( "width", m_fWidth );
!   col.setAttribute( "column", m_iColumn );
  
    return col;
  }
***************
*** 263,269 ****
      if ( !ok ) return false;
    }
  
!   m_iColumn = col.attribute( "col" ).toInt( &ok );
    if ( !ok ) return false;
  
    // Validation
--- 263,269 ----
      if ( !ok ) return false;
    }
  
!   m_iColumn = col.attribute( "column" ).toInt( &ok );
    if ( !ok ) return false;
  
    // Validation



[prev in list] [next in list] [prev in thread] [next in thread]