[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: Embedding
From:       David Faure <faure () kde ! org>
Date:       1999-09-14 23:43:33
[Download RAW message or body]

On Wed, Sep 15, 1999 at 12:46:27AM +0200, Reginald Stadlbauer wrote:
> On Wed, 15 Sep 1999, David Faure wrote:
> >(I'm posting this now in order to let some time to reach a decision.
> >Meanwhile, I'll try to actually fix embedding :))
> 
> I just realized that embedding doesn't crash anymore! I can embed KSpreda in
> KPresenter, KWord in KPresenter, KPresenter in KWord, .... and it doesn't
> crash. I can even save + load it without crashing. David, what did you do? :-)

Hehe. Me ? Nothing.
No, really. I only touched the saving & loading stuff, nothing else.
(And reported one reason of crash to you - did you fix it ? :) )

I'm investigating this stuff about saving children documents...
I wish Torben could help me understanding why he did things this way...
Does anyone know why he made a list of direct AND indirect children
in the root document, and then saved the list all at once ?
It's very complex, and for quite nothing. Each doc could save itself and
its children, instead of registering itself and its children to be saved
by the main doc... The store IDL interface is there for exactly that purpose...
(And this isn't even used for loading...)

I said it's complex because for this he had to create the internal
class KoDocument::SimpleDocumentChild, which hold (corba) pointer + url to the
document, those items being put in one list in the main document.

So for one embedded document, you have the KoDocument instance (but
usually in another process), a KoDocumentChild instance, and (when saving)
a SimpleDocumentChild, each holding a copy of the URL... Say hello
to confusion when updating the URL (to a store-like URL) !

Before I dump all this to try something simpler, I would have very much
preferred his opinion on this...

Well, trying to cc:. We'll see.
But if anybody else knows about this... 

-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://www.insa-lyon.fr/People/AEDI/dfaure/index.html 
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]