[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: KOffice Lies about requirements and then refuses to accept bug
From:       David Faure <faure () kde ! org>
Date:       2006-11-08 11:13:18
Message-ID: 200611081213.20151.faure () kde ! org
[Download RAW message or body]

On Wed Nov 8 2006, John McCann wrote:
> I guess no one bothered to try to build it on 3.3.0 as I believe you
> need 3.4 at a minium for the setShadeSortColumn
> koOpenPaneBase.cc: In constructor
> `KoOpenPaneBase::KoOpenPaneBase(QWidget*, const char*, uint)':
> koOpenPaneBase.cc:50: error: 'class KListView' has no member named
> 'setShadeSortColumn'

Damn. I had fixed that error in another file but that one has the same problem.
You can find the fix attached.

The bugs.kde.org version requirement is a bit of a complicated matter - for anything
else than koffice (which is released separately), like for konqueror, we have to require 
the latest version of KDE, otherwise we get swamped with old useless reports.
In fact, if you report a bug with koffice-1.6 built on kdelibs-3.3 it works. It's just that
in your case you couldn't use koffice to report the bug since it wasn't compiled yet.
Editing the parameters in the URL might have been a way to work around it.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

["fix.diff" (text/x-diff)]

Index: koOpenPaneBase.ui
===================================================================
--- koOpenPaneBase.ui	(revision 594577)
+++ koOpenPaneBase.ui	(working copy)
@@ -58,9 +58,6 @@
                         <property name="resizeMode">
                             <enum>LastColumn</enum>
                         </property>
-                        <property name="shadeSortColumn">
-                            <bool>false</bool>
-                        </property>
                     </widget>
                     <widget class="KPushButton">
                         <property name="name">
Index: KoOpenPane.cpp
===================================================================
--- KoOpenPane.cpp	(revision 594577)
+++ KoOpenPane.cpp	(working copy)
@@ -102,6 +102,9 @@ KoOpenPane::KoOpenPane(QWidget *parent, 
 
   m_sectionList->header()->hide();
   m_sectionList->setSorting(0);
+#if KDE_IS_VERSION(3,4,0)
+  m_sectionList->setShadeSortColumn(false);
+#endif
   connect(m_sectionList, SIGNAL(selectionChanged(QListViewItem*)),
           this, SLOT(selectionChanged(QListViewItem*)));
   connect(m_sectionList, SIGNAL(pressed(QListViewItem*)),


____________________________________
koffice mailing list
koffice@kde.org
To unsubscribe please visit:
https://mail.kde.org/mailman/listinfo/koffice


[prev in list] [next in list] [prev in thread] [next in thread]