[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Re: KoUnitDoubleSpinBox::valueChanged vs value()
From:       David Faure <faure () kde ! org>
Date:       2005-10-31 11:21:48
Message-ID: 200510311221.49627.faure () kde ! org
[Download RAW message or body]

On Sunday 30 October 2005 17:22, Tymoteusz Majewski wrote:
> Hi!
> Just wanted to point that
> signal KoUnitDoubleSpinBox::valueChanged( double ) is always sent with
> the value visible in the spinbox (so in current units)
> and 
> the value() function returns value in pt (using KoUnit::fromUserValue).
> 
> This can be a bit confusing especially to someone new like me and it
> took me quite some time to figure out what is going on.
> 
> I guess it won't be changed now, but maybe the authors can provide
> signal KoUnitDoubleSpinBox::valueChangedInPt( double ) and send it
> whenever valueChange is emited. 
> 
> This applies to KoUnitDoubleSpinComboBox as well.

IMHO valueChanged(double) should emit the value in pt.
The whole unit stuff should be as internal to the class as possible, the app only
cares about pt values.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

____________________________________
koffice mailing list
koffice@kde.org
To unsubscribe please visit:
https://mail.kde.org/mailman/listinfo/koffice
[prev in list] [next in list] [prev in thread] [next in thread]