[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmymoney-devel
Subject:    Re: Patch/branch to hide liabilities that have zero balance
From:       Jeremy Whiting <jpwhiting () kde ! org>
Date:       2019-06-16 15:35:33
Message-ID: CADWV2K62yma9b=KDb7WSu+EZp0aWcwro_GmvSTfqGAuz-8k8cA () mail ! gmail ! com
[Download RAW message or body]

Gotcha, somehow yesterday I couldn't recall how to create a new revision in
phabricator. it's there now.

On Sun, Jun 16, 2019 at 3:33 AM Thomas Baumgart <thb@net-bembel.de> wrote:

> Jeremy,
>
> On Sonntag, 16. Juni 2019 05:05:32 CEST Jeremy Whiting wrote:
>
> > Hello,
> >
> > It's been far too long since I've last made a change to some kde
> repository
> > that I don't maintain (and those that I do also tbh) I came up with a
> > quick/small patch to hide the liability accounts that have a zero balance
> > on the home screen. It cleans up my home screen quite a bit since I have
> > some liability accounts I haven't closed, but that have a zero balance
> and
> > don't typically need to be concerned about. I've pushed the patch to a
> > hide-zero-liabilities branch and attached it here. Is phabricator
> typically
> > used for code review lately? or just pushing branches and mentioning it
> in
> > the mailing list here? or something else entirely?
>
> Phabricator is the way to go (until we move to Gitlab when the general
> decision has been made).
>
> The patch looks good in general. I do have a few minor comments and
> improvements, though. Would it make sense to extent it to also cover asset
> accounts? But we could also discuss that on Phabricator.
>
> Thomas
>
>
> --
>
> Regards
>
> Thomas Baumgart
>
> https://www.signal.org/       Signal, the better WhatsApp
> -------------------------------------------------------------
> God is real... unless declared an integer
> -------------------------------------------------------------
>

[Attachment #3 (text/html)]

<div dir="ltr">Gotcha, somehow yesterday I couldn&#39;t recall how to create a new \
revision in phabricator. it&#39;s there now.</div><br><div class="gmail_quote"><div \
dir="ltr" class="gmail_attr">On Sun, Jun 16, 2019 at 3:33 AM Thomas Baumgart &lt;<a \
href="mailto:thb@net-bembel.de">thb@net-bembel.de</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Jeremy,<br> <br>
On Sonntag, 16. Juni 2019 05:05:32 CEST Jeremy Whiting wrote:<br>
<br>
&gt; Hello,<br>
&gt; <br>
&gt; It&#39;s been far too long since I&#39;ve last made a change to some kde \
repository<br> &gt; that I don&#39;t maintain (and those that I do also tbh) I came \
up with a<br> &gt; quick/small patch to hide the liability accounts that have a zero \
balance<br> &gt; on the home screen. It cleans up my home screen quite a bit since I \
have<br> &gt; some liability accounts I haven&#39;t closed, but that have a zero \
balance and<br> &gt; don&#39;t typically need to be concerned about. I&#39;ve pushed \
the patch to a<br> &gt; hide-zero-liabilities branch and attached it here. Is \
phabricator typically<br> &gt; used for code review lately? or just pushing branches \
and mentioning it in<br> &gt; the mailing list here? or something else entirely?<br>
<br>
Phabricator is the way to go (until we move to Gitlab when the general decision has \
been made). <br> <br>
The patch looks good in general. I do have a few minor comments and improvements, \
though. Would it make sense to extent it to also cover asset accounts? But we could \
also discuss that on Phabricator.<br> <br>
Thomas<br>
<br>
<br>
-- <br>
<br>
Regards<br>
<br>
Thomas Baumgart<br>
<br>
<a href="https://www.signal.org/" rel="noreferrer" \
                target="_blank">https://www.signal.org/</a>           Signal, the \
                better WhatsApp<br>
-------------------------------------------------------------<br>
God is real... unless declared an integer<br>
-------------------------------------------------------------<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]