'Re: [Kmymoney-devel] Review Request 110212: Add payee merge functionality'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmymoney-devel
Subject:    Re: [Kmymoney-devel] Review Request 110212: Add payee merge functionality
From:       Cristian_Oneț <onet.cristian () gmail ! com>
Date:       2014-03-26 20:57:18
Message-ID: 20140326205718.24148.10013 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110212/#review54232
-----------------------------------------------------------

I'll take a look at it until the weekend and push it if it seems OK.

- Cristian Oneț

On March 26, 2014, 5:01 p.m., Felipe Tonello wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110212/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 5:01 p.m.)
> 
> 
> Review request for KMymoney.
> 
> 
> Repository: kmymoney
> 
> 
> Description
> -------
> 
> payee: Does not merge when payees are empty
> 
> When there is no transactions to be merged we don't need to merge. In fact if
> we don't stop there the rest of the code will delete the payees, which is a
> behavior for delete payees functionality.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> payee: Show transactions from multiple payees
> 
> This patch allow users to have see all transactions that they
> will merge.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> payee: Added Payees Merge KButton
> 
> Adds a button next to the delete payee and enables it only when multiple
> payees are selected.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> payee: Added payee_merge KAction
> 
> Added KAction to the context menu and connected to the slotPayeeMerge().
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> payee: Added support to Merge Payees
> 
> This patch implements the opeartion to merge payees. This is done by reusing
> the payee delete slot, modifying it to support merge operation and add support
> to it in KPayeeReassignDlg dialog.
> 
> The main difference between delete a payee and merging a payee is that when
> merging the user can merge to a new payee. So the modification was done to
> support this use-case.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> payee: change slotPayeeNew(...) to return boolean value
> 
> This is usefull if the user of that function wants to know if the user created
> a new payee or not.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> payee: Make PayeeReassignDlg support other operations then delete
> 
> This is useful so it can be implemented a merge opration and maybe others in
> future as well.
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> payee: Better explanation when deleting payee
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> 
> 
> Diffs
> -----
> 
>   kmymoney/dialogs/kpayeereassigndlgdecl.ui 2cf563d4ea755e8d89ff2587fa677f14453cbaa5 
>   kmymoney/dialogs/kpayeereassigndlg.cpp 8bdb25c0b3478c42715fac9f052903ed45b3614c 
>   kmymoney/dialogs/kpayeereassigndlg.h a348d2b9fdc68a7c56a616a862a3373ef35aa0ba 
>   kmymoney/kmymoney.h 56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca 
>   kmymoney/kmymoney.cpp 6b96b9790d0ee5b5d34e6cfd382b03e9a103c9e6 
>   kmymoney/kmymoneyui.rc 65afc920cef7091e3138c9acf75f73ec96929445 
>   kmymoney/views/kpayeesview.h c747e691f6509c7bf60201dfb3cc77e9f939a7c5 
>   kmymoney/views/kpayeesview.cpp 7252241886e05f00555d16dc1388b9d6ecef36a2 
>   kmymoney/views/kpayeesviewdecl.ui 6efb2ae5f94383851ee2ab15da36187b7079815a 
> 
> Diff: https://git.reviewboard.kde.org/r/110212/diff/
> 
> 
> Testing
> -------
> 
> Normal UI test going trough all the possible options of users input.
> 
> 
> Thanks,
> 
> Felipe Tonello
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/110212/">https://git.reviewboard.kde.org/r/110212/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;ll take a look at \
it until the weekend and push it if it seems OK.</pre>  <br />

<p>- Cristian Oneț</p>

<br />
<p>On March 26th, 2014, 5:01 p.m. UTC, Felipe Tonello wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KMymoney.</div>
<div>By Felipe Tonello.</div>

<p style="color: grey;"><i>Updated March 26, 2014, 5:01 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">payee: Does not merge when payees are empty

When there is no transactions to be merged we don&#39;t need to merge. In fact if
we don&#39;t stop there the rest of the code will delete the payees, which is a
behavior for delete payees functionality.