[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Bug#30475: crash when typing f while kmail starts
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-08-21 7:42:21
[Download RAW message or body]

On Monday 20 August 2001 23:33, Ingo Klöcker wrote:
>
> So how should we/I proceed? Should I simply commit the patch I posted
> on Sunday at 11:54. This patch makes the message related actions simply
> bail out if the codec still hasn't been set. As the codec is normally
> always set this patch will just prevent the crash.

I think, that should do it for now.

> BTW, why do you think a valid codec could be set in
> KMMessage::fromString? IMHO this should be done in the constructor
> because the constructor is only called once for every message and all
> information which is needed to automatically determine a reasonable
> codec is already there. Later it should of course be overwritten by the
> code in KMReaderWin.

The KMMessage constructor doesn't know anything about the content of the 
message.

Actually the whole problem only appears, because we try to support broken 
mails without a proper charset header.

Maybe the most clean solution would be, to completely remove again this 
mCodec variable from KMMessage and read the charset always from the mail 
headers when required. It is also possible to have different charsets in 
different body parts.
Only when displaying the message, replying, forwarding, redirecting, etc., 
the function that does that needs also to know, possibly via a parameter, if 
it should use a special codec or not.

I think, that can wait, until the new mime parsing code is ready. The code in 
KMReaderWin then probably anyway needs some changes, for example to display 
multipart/related (HTML mail with attachemnts) or multipart/signed properly.

Regards,
Michael Häckel
_______________________________________________
Kmail Developers mailing list
Kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]