[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Bug#30475: crash when typing f while kmail starts
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2001-08-20 21:33:57
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Montag, 20. August 2001 14:35, Michael Häckel wrote:
> On Monday, 20. August 2001 14:06, Don Sanders wrote:
> > Hmm. How the KMReaderWin code sets the codec of the current
> > message is unnecessarily hard to follow.
>
> The problem is, that the codec can also depend on the setting in the
> menu of the main window and the KMMessage constructor doesn't know
> anything about any window.
> This codec is set in KMReaderWin::setMsg(). It is set to NULL for
> auto detection.
>
> It would possibly make sense, to set already a valid codec in
> KMMessage::fromString and possibly override that setting later.
> However that might be just time wasting in many cases.

So how should we/I proceed? Should I simply commit the patch I posted 
on Sunday at 11:54. This patch makes the message related actions simply 
bail out if the codec still hasn't been set. As the codec is normally 
always set this patch will just prevent the crash.

BTW, why do you think a valid codec could be set in 
KMMessage::fromString? IMHO this should be done in the constructor 
because the constructor is only called once for every message and all 
information which is needed to automatically determine a reasonable 
codec is already there. Later it should of course be overwritten by the 
code in KMReaderWin.

Regards,
Ingo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7gYJFGnR+RTDgudgRAkgyAJ49JsqRy9aXxbdgoCf3ClxB+R1u7ACfTFJL
2PUNTaYP5bhnp2BFgawlELI=
=mF05
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]