[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Kpgp sane passphrase handling
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2001-06-30 14:38:47
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday, 30. June 2001 00:07, Marc Mutz wrote:
> Attached is the current version of my sane passphrase patch for Kpgp.
> I have it in production now and there are no more known issues (the
> last one being the busy-cursor being shown while the passphrase
> dialog was up.)
>
> Although this change looks like it would violate the message freeze,
> this is in fact not the case, since the new dialog is from kdelibs.
> The remaining changes that I'll make after 2.2 are commented in the
> source.(search for ###).

I have two remarks/questions:

1.) It's really annoying that I always have to check the "Keep 
password" checkbox in the new password dialog although I've checked the 
"Keep password in memory" option in the configuration dialog. I had a 
look at kpassdlg.* and it doesn't seem to be possible to call the 
dialog with the "Keep password" checkbox checked by default (if the 
user wants to keep the password in memory).
Actually the checkbox is checked/unchecked according to the value of 
"Keep" in the "Passwords" section in the kdeglobals config file. This 
global value seems to be changeable in KControl->Passwords. Therefore I 
guess we can remove the extra "Keep password in memory" option in the 
configuration dialog. But this would obviously violate the GUI freeze. 
OTOH we shouldn't keep a nonfunctional checkbox (because some people 
might complain about it's nonfunctionality and by this waste their and 
our time). Therefore it might be preferable to keep the old password 
dialog till after KDE2.2. Your other non GUI changes (i.e. storing the 
password in a char * instead of a QString) can of course go into KDE2.2.

2.) Have a look at the following code snippet:
      if ( passDlg->exec() == QDialog::Accepted ) {
	if ( !setPassPhrase( passDlg->password() ) ) {
	  delete passDlg;
	  // ### set new errmsg after message freeze:
	  //	  errMsg = i18n("Out of memory or passphrase too long\n"
	  //			"(Must be less than 1024 chacacters).");
	  errMsg = i18n("The passphrase is missing.");
	  return false;
	}
	setStorePassPhrase( passDlg->keep() );
      } else {
	wipePassPhrase();
	setStorePassPhrase( false );
      }

Why do you setStorePassPhrase( false ) if the user hits Cancel in the 
password dialog? IMHO this line should be removed.

I noticed a typo in the new error message: "chacacters" -> "characters".

Regards,
Ingo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7PeR/GnR+RTDgudgRAr2uAJ4woLIres5ZAxPZ2iW8dxfGt0hEWACg2nro
Sjg9GT8a8HqNPoqQ2hcgbuA=
=sikz
-----END PGP SIGNATURE-----
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]