[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Why, oh why? -or- scoring
From:       Guillaume Laurent <glaurent () telegraph-road ! org>
Date:       2001-06-01 13:17:25
[Download RAW message or body]

On Friday 01 June 2001 14:13, Marc Mutz wrote:

> IIRC, scoring is a relatively new feature. So one should expect that
> the implementor is interested more in clean abstraction than in quickly
> hacking this feature in, having had a look at kmheaders.cpp and
> friends, right?

I did.

> Why isn't there a kernel->scoringManager()? I reckon that implementing
> somthing that smells like filtering should be implemented along the
> lines that the earlier filtering code was programmed along, no?
>
> Why can't I just use something like
> Q> msgScre = kernel->scoringManager()->score(myMsg);

Because scoring can only be done within a folder, as rules are on a 
per-folder basis.

> Why was a KNode class (I assume this, because scoring has to be done by
> creating a KScorable_Article_, which simply takes the message as
> string), w/o further integration into the KMail framework, brutally
> pushed into KMail just to implement a rarely-used feature?

It was initially a KNode class which was actually made abstract enough so as 
to be easily re-useable from KMail. There's nothing wrong with it. It used to 
be based on KMessage but that proved to be *way* too slow.

> To the one that implemented scoring in KMail (and I somehow doubt that
> this is Espen Sand, as stated in kmscoring.h...):

That's me.

> If you care for filtering based on "score" or a "set score", "add
> score" etc. filter action, you have two options:

I'm more or less interested in score-based filtering, but not on a "set 
score" action as it simply doesn't make any sense. You'd be duplicating what 
scoring is doing in the first place (e.g. setting a score).

> 2.) make it possible to score a message
> a. with no parent folder

As I said, that doesn't make sense (rules are on a per-folder basis).

> b. without big overhead

Michael wouldn't have let the patch in otherwise :-)

It seems to me you're totally misunderstanding what scoring is about and how 
it works.

The only feature I'd like to have actually is the ability to flag messages 
which have a score higher than some value. But this will have to wait for the 
"extra listview columns" issue to be settled. (and while I'm at it : I fail 
to see the usefulness of the "flagged" status if it's on the same column as 
new/read/replied, so yes an extra column should be added, if only for the 
possibility to sort on it).

-- 
Guillaume
http://www.telegraph-road.org
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]