[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: PATCH : scoring, take 2
From:       Guillaume Laurent <glaurent () telegraph-road ! org>
Date:       2001-04-16 10:00:44
[Download RAW message or body]

On Monday 16 April 2001 11:42, Michael Häckel wrote:

> BTW: Are you sure that it is not faster, if you use "const QCString&"
> instead of QString, since the message might not be copied then or is that
> anyway not the case?

Mmh, where ? In KMScorableArticle ?

> I still think, that only messages in folders with a scoring rule defined
> should be scored before this patch goes into CVS because of that slowdown
> and also because of the score column displayed in all folders.

Agreed. I didn't mean this as a definitive version, just a "please tell me 
what you think"-version:-).

> Also I still didn't manage to get any score displayed in the score column
> which makes the patch pretty useless for me although I get following
> debugging output when switching to that folder. Don't know if I'm doing
> something wrong though.

Quite strange. Given the debug messages, you should at least see some 
messages with a non-0 score. I had that problem at some point because after 
setting the score I wouldn't call irefresh() on the KMHeaderItem. Could it be 
that the recent speedup patch would have broken this ?

> The score dialog still has a few bugs, but they are probably in
> libkdenetwork.

I may still try to look at them and check with Mathias Waack.

-- 
					Guillaume.
					http://www.telegraph-road.org
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]