[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Bug#4148 "Privacy bug": mail may be sent unencrypted w/o notice
From:       Andreas Gungl <Andreas.Gungl () osp-dd ! de>
Date:       2000-05-31 7:51:32
[Download RAW message or body]

Malte Starostik schrieb:
> 
> Ich hoffe, jetzt stimmt die Adresse :)
Ja, zumindest die im Büro: Andreas.Gungl@osp-dd.de
Privat wäre es die folgende: a.gungl@gmx.de
;-)
 
> > Malte I (finally :-) applied Andreas' patch please upgrade to KMail 1.1.50
> > (check you have the right version) and try again.
> >
> > Please report another bug if the problem persists.
> >
> > BFN,
> > Don.
> 
> Thanks alot!
> Unfortunately the "Encrypt" button in the warning dialog does nothing. That
> should be fixed by the patch below. Should means, I can't really test (see
> below). If you don't have other changes pending in kpgp.cpp, I could commit.
> The second problem: the "encrypt anyway" thing is of no help with PGP 6 which
> doesn't have an equivalent to NoBatchInvalidKeys like PGP 5. At least I
> couldn't find one in the manual. (Andreas?).

I also didn't find such an option. In general I think, the PGP interface
is very poor. There are some error codes, but in most cases you can't
use them. So you must parse the output. :-(
I'll test your patch and inform you.

Andreas

> -Malte
> 
> diff -u -r1.57 kpgp.cpp
> --- kpgp.cpp    2000/04/21 04:52:40     1.57
> +++ kpgp.cpp    2000/05/30 21:07:52
> @@ -365,7 +365,7 @@
>        pgp->clearOutput();
>        return true;
>      }
> -    if(ret == 0) status = doEncSign(persons, sign, true);
> +    if(ret == KMessageBox::Yes) status = doEncSign(persons, sign, true);
>    }
>    if( status & KpgpBase::MISSINGKEY)
>    {

[prev in list] [next in list] [prev in thread] [next in thread]