[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Memory usage (Re: QCString construction)
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2007-02-15 23:26:01
Message-ID: 200702160026.16755.dfaure () klaralvdalens-datakonsult ! se
[Download RAW message or body]

On Thursday 15 February 2007, Ingo Klöcker wrote:
> +  KMMessage msg;
> +  delete msg.mMsg;
> +  msg.mMsg = new DwMessage( *mMsg );
> 
> I'd be more comfortable if there was a KMMessage::fromDwMessage( const 
> DwMessage &dwMsg ) doing the last two lines so that the above would 
> simply become
> + KMMessage msg;
> + msg.fromDwMessage( *mMsg );

Actually, we could even save the new/delete (and the new method), by simply doing
KMMessage msg( new DwMessage( this->mMsg ) );
What do you think?

-- 
David Faure, faure@kde.org, dfaure@klaralvdalens-datakonsult.se
KDE/KOffice developer, Qt consultancy projects
Klarälvdalens Datakonsult AB, Platform-independent software solutions
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]