[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Memory usage (Re: QCString construction)
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2007-02-15 22:35:54
Message-ID: 200702152335.57075 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 15 February 2007 17:10, David Faure wrote:
> On Wednesday 14 February 2007, Ingo Klöcker wrote:
> > On Wednesday 14 February 2007 12:50, David Faure wrote:
> > > But at least sending a 30MB attachment in a signed mail went from
> > > VmPeak:  1324284 kB
> > > VmSize:   877792 kB
> > > VmRSS:    530372 kB
> > > VmData:   719364 kB
> > > to
> > > VmPeak:   968596 kB
> > > VmSize:   601560 kB
> > > VmRSS:    325900 kB
> > > VmData:   458020 kB
> > > (data measured after signing, and while sending)
> >
> > Looks very promising.
> >
> > > There's still too much memory consumption in kmsender (due to
> > > KMMessage::asSendableString()
>
> Wow. With the attached patch - note the new solution for
> asSendableString - it gets down to:
>
> -obelix- dfaure 17:07 ~>grep Vm'[PRSD][eiSa]' /proc/`pidof
> kmail`/status VmPeak:   642944 kB
> VmSize:   275912 kB
> VmRSS:    129228 kB
> VmData:   132368 kB

Excellent.

+  //KMMessage msg( *this );
+  KMMessage msg;
+  delete msg.mMsg;
+  msg.mMsg = new DwMessage( *mMsg );

I'd be more comfortable if there was a KMMessage::fromDwMessage( const 
DwMessage &dwMsg ) doing the last two lines so that the above would 
simply become
+ KMMessage msg;
+ msg.fromDwMessage( *mMsg );

Other than that the patch looks good.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]