[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Address completion (Re: Duplicates)
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2006-09-19 18:46:37
Message-ID: 200609192046.49512 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 14 September 2006 21:12, Christian wrote:
> messing around with GUI and config is a bit scary ... with this code
> example I wanted to show one possible solution. Another reason for
> not changing the GUI part, there are some issues I don't
> understand/know:
> 1. porting to qt4 is on the way, does it make sense to keep patching
> branch3.5? Or should the person porting the code use the idea and
> implement it in qt4?

It still makes sense to add smaller improvements to the 3.5 branch. Of 
course, it would also be good if the improvements were ported to Qt4 
after they have been added to 3.5.

> 2. If I can't come up with a solution for the other completion modes,
> who will decide on removing them from kmail?

You could probably simply use your KMailCompletion for the 
CompletionPopup mode and the old KCompletion for the other modes. I 
haven't really checked whether this is easily doable.

> > Coding comments:
>
> ;-) ... and I thought I could pass without comments ... ;-)

Another comment:
You should pass the QStringLists as const-references instead of as 
pointers to the methods, i.e. use
  void addCompletionItem( const QString& string, int weight, int source, 
const QStringList & keyWords );
and
  void addItemWithKeys( const QString& item, int weight, const 
QStringList & keyWords );

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]