[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] for #87119 - kmail crashes after trying to
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-08-31 22:27:57
Message-ID: 200409010028.04769 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 29 August 2004 23:34, Andreas Gungl wrote:
> Hi,
>
> the attached patch fixes http://bugs.kde.org/show_bug.cgi?id=87119 by
> changing the way how modifications to toolbar and menu are done. It
> uses the XMLGUI way to do so - thanks to Simon and Till for their
> valuable help.
>
> The patch can be immediately backported to the 3.3 branches. However
> note, that in kmmainwidget.cpp (around line 3309) an if statement is
> commented. To avoid a string change, I've coupled the plugging of
> shortcut filters (AKA ad-hoc filters) into menu _and_ toolbar. The
> next release could allow to separate this. But this means additional
> changes in the GUI while the infrastructure is already there.
>
> Till and Ingo, can you have a carefull look at the patch? Comments
> are welcome.

Thanks a lot for the patch.

One problem:
- The "Apply Filter" entry in the context menu in the header pane is 
disabled.

One annoyance:
- There's currently no way not to have the icons in the toolbar. Since 
we need a new setting for this in the filter configuration which we 
can't backport I don't really know whether we should backport this and 
thus force all users of KMail 1.7 to live with having all icons in the 
toolbar. But since it fixes some crashes it's probably worth 
backporting it anyway. A possible interim solution for the 3.3 branch 
would be to only add those filters to the toolbar for which the user 
has defined an icon.

A minor nitpick: There should IMO be a line separator before the filter 
actions in the toolbar.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]