--===============0416168555==
Content-Type: multipart/signed; boundary="nextPart1477527.JmI7Kue1fx";
	protocol="application/pgp-signature"; micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1477527.JmI7Kue1fx
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sunday 29 August 2004 23:34, Andreas Gungl wrote:
> Hi,
>
> the attached patch fixes http://bugs.kde.org/show_bug.cgi?id=3D87119 by
> changing the way how modifications to toolbar and menu are done. It
> uses the XMLGUI way to do so - thanks to Simon and Till for their
> valuable help.
>
> The patch can be immediately backported to the 3.3 branches. However
> note, that in kmmainwidget.cpp (around line 3309) an if statement is
> commented. To avoid a string change, I've coupled the plugging of
> shortcut filters (AKA ad-hoc filters) into menu _and_ toolbar. The
> next release could allow to separate this. But this means additional
> changes in the GUI while the infrastructure is already there.
>
> Till and Ingo, can you have a carefull look at the patch? Comments
> are welcome.

Thanks a lot for the patch.

One problem:
=2D The "Apply Filter" entry in the context menu in the header pane is=20
disabled.

One annoyance:
=2D There's currently no way not to have the icons in the toolbar. Since=20
we need a new setting for this in the filter configuration which we=20
can't backport I don't really know whether we should backport this and=20
thus force all users of KMail 1.7 to live with having all icons in the=20
toolbar. But since it fixes some crashes it's probably worth=20
backporting it anyway. A possible interim solution for the 3.3 branch=20
would be to only add those filters to the toolbar for which the user=20
has defined an icon.

A minor nitpick: There should IMO be a line separator before the filter=20
actions in the toolbar.

Regards,
Ingo

--nextPart1477527.JmI7Kue1fx
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBBNPt0GnR+RTDgudgRAmHHAJwMRKnmgSy31/FCD8zuolm/UVZsgACeML/z
UJzVfu9HBYxhwN5bd1iADIo=
=hmGl
-----END PGP SIGNATURE-----

--nextPart1477527.JmI7Kue1fx--

--===============0416168555==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

--===============0416168555==--