[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Fix loose ends in crypto support: pt.4+5/??:
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-05-31 15:48:32
Message-ID: 200405311748.33518 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 31 May 2004 17:31, Marc Mutz wrote:
> On Monday 31 May 2004 17:05, Ingo Klöcker wrote:
> > The patch is lacking some whitespace, e.g. between parentheses and
> > their contents. (I know, not before the merge. But they should've
> > been there in the first place.)
>
> I've not found any missing whitespace when just scanning the patch.

Then I guess I was lucky to see the following two while scanning the 
patch:
+  mAutoSave->setSpecialValueText(i18n("No autosave"));
+  mAutoSave->setSuffix(i18n(" min"));

> If you mean SIGNAL(toggled(bool)), I consider this a special case,
> since the SIGNAL() is _one_ arg. (I also believe it reduces the
> amount of storage and the time needed to parse the signal spec when
> all superfluous whitespace is removed, since it's stringified by that
> macro).
>
> The other one I found is i18n("foo"). I've got a habit of leaving the
> whitespace out of there, perhaps since the quotes make up for it
> somewhat. In some sense, it might even make more sense, since it's a
> more like a SIGNAL() than a function call, but don't get me started
> on finding an explanation for this. :)

Since xemacs automatically adds spaces after '(' and before ')' I've 
gotten used to always use spaces. It's simply a pain to remove spaces 
that xemacs adds automatically. So I don't do it.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]