From kmail-devel  Mon May 31 15:48:32 2004
From: Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date: Mon, 31 May 2004 15:48:32 +0000
To: kmail-devel
Subject: Re: [PATCH] Fix loose ends in crypto support: pt.4+5/??:
Message-Id: <200405311748.33518 () erwin ! ingo-kloecker ! de>
X-MARC-Message: https://marc.info/?l=kmail-devel&m=108601853306081
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1421477420=="

--===============1421477420==
Content-Type: multipart/signed; protocol="application/pgp-signature";
	micalg=pgp-sha1; boundary="Boundary-02=_RP1uADtoGUj+/xN"
Content-Transfer-Encoding: 7bit

--Boundary-02=_RP1uADtoGUj+/xN
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Monday 31 May 2004 17:31, Marc Mutz wrote:
> On Monday 31 May 2004 17:05, Ingo Kl=F6cker wrote:
> > The patch is lacking some whitespace, e.g. between parentheses and
> > their contents. (I know, not before the merge. But they should've
> > been there in the first place.)
>
> I've not found any missing whitespace when just scanning the patch.

Then I guess I was lucky to see the following two while scanning the=20
patch:
+  mAutoSave->setSpecialValueText(i18n("No autosave"));
+  mAutoSave->setSuffix(i18n(" min"));

> If you mean SIGNAL(toggled(bool)), I consider this a special case,
> since the SIGNAL() is _one_ arg. (I also believe it reduces the
> amount of storage and the time needed to parse the signal spec when
> all superfluous whitespace is removed, since it's stringified by that
> macro).
>
> The other one I found is i18n("foo"). I've got a habit of leaving the
> whitespace out of there, perhaps since the quotes make up for it
> somewhat. In some sense, it might even make more sense, since it's a
> more like a SIGNAL() than a function call, but don't get me started
> on finding an explanation for this. :)

Since xemacs automatically adds spaces after '(' and before ')' I've=20
gotten used to always use spaces. It's simply a pain to remove spaces=20
that xemacs adds automatically. So I don't do it.

Regards,
Ingo

--Boundary-02=_RP1uADtoGUj+/xN
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAu1PRGnR+RTDgudgRAsFcAKDDO6qdilNlOo1l+6Rj+cBvRdtCVwCgq0Rw
hIXLJ7N05NBQuSwyHE921Y0=
=fEhZ
-----END PGP SIGNATURE-----

--Boundary-02=_RP1uADtoGUj+/xN--

--===============1421477420==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

--===============1421477420==--