[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] make kio_imap use peek and kmail set imap read status
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-12-30 17:25:07
Message-ID: 200312301825.11770 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 30 December 2003 14:18, Till Adam wrote:
> -    if (message()->isNew() || message()->isUnread() || message()->isRead())
> -      message()->setStatus(KMMsgStatusRead); 
> +    SerNumList serNums;
> +    if (message()->isNew() || message()->isUnread()) {
> +      serNums.append( message()->getMsgSerNum() );
> +    }
> +
> +    KMCommand *command = new KMSetStatusCommand( KMMsgStatusRead, serNums );
> +    command->start(); 

I guess it doesn't make much sense to call the KMSetStatusCommand with 
an empty list of serial numbers. So the command should be moved into the 
if-branch.

>      if ( message()->isNew() || message()->isUnread() ) {
>        KMMessage * receipt = message()->createMDN( MDN::ManualAction,
> -                                                 MDN::Displayed,
> -                                                 true /* allow GUI */ );
> +        MDN::Displayed, true /* allow GUI */ ); 

This indentation doesn't look right.

About the change in kio_imap. It would be nicer if it would be possible 
to use BODY and BODY.PEEK (depending on the situation). Isn't it 
possible to extend the IMAP slave accordingly? Then no apps that rely on 
the current behavior would break.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]