[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] make kio_imap use peek and kmail set imap read status
From:       Bo Thorsen <bo () sonofthor ! dk>
Date:       2003-12-30 14:30:08
Message-ID: 200312301530.16588.bo () sonofthor ! dk
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 30 December 2003 14:18, Till Adam wrote:
> Dear imap crowd,
>
> the attached smll patches to kio_imap4 and kmail make it:
>
> o use peek instead of fetch to get a message, thereby _not_ setting the
> \seen flag on the server as we do currently for each mail that is
> viewed o set read status explicitely just like for local mails
>
> This has several advantages:
>
> o local and imap status don't go out of sync resulting in wrong unread
> counts. There are bugs about this.
> o mail doesn't magically become read just because it was synced with
> dimap (I think. Bo?) There are bugs about this.
> o fixes The Gassauer Scenario (TM). One kmail at work, one at home.
> Open a folder in one, skip over a few messages, but read only few of
> them. Go home and find all of them marked as read. Sucks. There are
> bugs about this as well.
>
> I've been running with those changes for a while and no problems. Since
> it's fairly late in the game for 3.2 I'm in two minds as to whether we
> should commit this. On the other hand, not committing the kio_imap4
> change now, will mean it won't be available for the stand alone pim
> release either, unless we release kdebase along with it, which is
> unlikely, right?
>
> Opinions?

General comment: Peek is correct, since just downloading the message is 
(as you state) not the same as reading it. Have you tested how konqueror 
works together with this patch?

The patch looks fine to me, but it touches an unsolved area of dIMAP. I 
need to do something about up- and downloading flags.

Don't take this as a "you can commit" review though, since I have not 
tried the patch and I have no time to do so before jan 2nd.

Bo.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]