[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] UI abstraction proposal (partially only)
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-06-04 22:18:24
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 04 June 2003 10:48, Don Sanders wrote:
> This is because majority of the KMail Kernel code is GUI free in the
> sense that it never blocks on user input. There are some exceptions,
> I see two calls to KMessageBox::sorry in kmfoldermaildir.

In kmfoldermbox there are also some message boxes.

> These exceptions are unfortunate regressions and it would be nice to
> eliminate them. It seems to me that this is basically what your patch
> is doing but for kmaddrbook instead of kmfolder.
> 
> That leads me to a question is kmaddrbook part of the KMail kernel
> code? I think this question is basically equivalent to can any of the
> kmaddrbook.cpp code be hit when KMail is being run as server process?
> (That's an actual not a hypothetical question).

After a quick research I'm convinced that the kmaddrbook.cpp code (which
consists of two classes with only static member functions) won't be
called by the server.

KMAddrBookExternal is only used here:
kmcommands.cpp:  KMAddrBookExternal::addEmail( KMMessage::decodeMailtoUrl( \
                mUrl.path() ), mParent );
kmcommands.cpp:  KMAddrBookExternal::openEmail( KMMessage::decodeMailtoUrl( \
                mUrl.path() ), mParent );
kmcomposewin.cpp:  KMAddrBookExternal::launch(this);
kmmainwidget.cpp:  KMAddrBookExternal::launch(this);
vcardviewer.cpp:  if (KMAddrBookExternal::addVCard(mAddressee, this))

KabcBridge is only used here:
kmcomposewin.cpp:    mMsg->setTo( KabcBridge::expandDistributionLists( to() ));
kmcomposewin.cpp:    mMsg->setCc( KabcBridge::expandDistributionLists( cc() ));
kmcomposewin.cpp:      mMsg->setBcc( KabcBridge::expandDistributionLists( mBcc ));
kmcomposewin.cpp:      mMsg->setHeaderField( "X-KMail-Recipients", \
                KabcBridge::expandDistributionLists( recips ) );
kmcomposewin.cpp:      msg->setTo( KabcBridge::expandDistributionLists( to() ));
kmcomposewin.cpp:      msg->setCc( KabcBridge::expandDistributionLists( cc() ));
kmcomposewin.cpp:      msg->setBcc( KabcBridge::expandDistributionLists( bcc() ));
kmcomposewin.cpp:        msg->setHeaderField( "X-KMail-Recipients", \
KabcBridge::expandDistributionLists( recips ) );

Regards,
Ingo


[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]