[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: adding timestamp to transmission completed statusbar message
From:       Marc Mutz <mutz () kde ! org>
Date:       2003-02-26 23:58:03
[Download RAW message or body]

On Wednesday 26 February 2003 15:29, Patrick S. Vogt wrote:
> > The other one needs readProfile() methods implemented for almost
> > every class that currently has readConfig(). Grep the source for
> > readConfig and you'll the how big that task is ;-)
>
> hmmm...  but why not implement it in KMSender?  
> Either directly in createSendProcFromString or after the sending
> failed in slotIdle.

KMail already has (hardcoded) profiles. You can even create your own, 
but only if you edit text files and put them in the right places. 
They're executed by the configuredialog. You can't do that in case you 
want the profile selector in the toolbar (except if you use a hidden 
config dialog - don't).

Of course, you could roll your own KMail/KMSender-only solution, that 
would probably be easy, but you shouldn't strive for easy solutions, 
but generic ones. The best solution is one that can go to kdelibs.

A KMSender-only solution has the problem that you have to sell those two 
profile managers to the user (and to the developers). Having SMTP 
profiles alongside KMail profiles isn't something that's desirable, is 
it?

<snip>
> > I don't have an opinion on this. It would probably be a nice
> > feature to begin with :-)
>
> so, whats about the patch, I send with my first email?
> Form the KMail TODO:
>         DS: (improve status showing, for concurrent account checking)
> I could include this quite easy.

I'm too tired right now to have a look at it. From a very brief glance, 
I like it, b/c it cleans up code. Except for the long parameter list of 
the setStatusMsgTransmissionCompleted() method, but I don't see a way 
to reduce that :-(

> sure I'd prefer to have a network profile framework.  
> but I cannot be done by sending patches for KMail... ;-)

You're not constrained to send patched to KMail only ;-) And even if you 
were, you could implement the full client side in KMail and just use a 
kicker applet to emit the right dcop signal. Then you could send it to 
core-devel for comments ;-)

> ... and to have a KMail menuentry would be a nice prework for this
> KDE-wide solution.

Adding a menu entry is almost the exact same work than listening to a 
dcop signal...

Marc

-- 
Ein Grundrecht auf Sicherheit steht bewusst nicht in der Verfassung.
  -- Sabine Leutheusser-Schnarrenberger (ehem. Bundesjustizministerin)

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]