[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Bug 54474] changing subject does not break thread
From:       Don Sanders <sanders () kde ! org>
Date:       2003-02-21 4:52:09
[Download RAW message or body]

On Thursday 20 February 2003 08:53, Ingo Klöcker wrote:
> On Tuesday 18 February 2003 06:21, Don Sanders wrote:
> > On Sunday 16 February 2003 22:47, Ingo Klöcker wrote:
> > > Actually I thought we were talking about the generation of
> > > In-reply-to and References headers for composed replies and not
> > > about threading received messages. It seems I misunderstood the
> > > original wish.
> >
> > Or perhaps I misunderstood it. Regardless the questions to be
> > considered for the receiving and sending cases are the same. But
> > I would like to concentrate on the receiving case for now.
> >
> > So starting over. I would like to implement subject based
> > threading. I see this task as consisting of two subtasks.
> >
> > 1) Breaking threads when messages have been incorrectly threaded
> > due to 'abuse' of the reply button.
> > 2) Adding to a thread when the mua used to create a message has
> > failed to set the reply-id header field correctly.
> >
> > For the moment I would like to just consider (1).
>
> Please concentrate on (2).

Ok. (2) is the one with all the votes (9319), so that's ok with me.

For (2) what I would like to do is if threading by replyidmd5 fails on 
a message being considered then look for a parent message with the 
same strippedsubjectmd5 as the considered message.

If such a parent message is found and it is less than 30 days older 
than the considered message then make the considered message a child 
of the parent message.

The parent message should also be a top level message I think.

This does have the limitation that messages threaded with subject 
based threading will only be made first generation children, but I 
think that's an improvement and good enough to start with. I'll work 
on a patch for that.

(But I think I should look at this local->imap move crash if no one 
else is taking if)

> After reading all arguments given in
> this thread I have reconsidered my set of conditions and now don't
> longer think that we should try to figure out whether a reply is
> actually a reply or not. It's simply not possible to do so.
>
> If you still want to consider (1) then please add a "break thread"
> action to KMail which can be used to manually reset the
> replyToIdMD5 (and possibly also the In-reply-to header).

Yeah, I understand that many people would prefer a break thread 
option. But this seems distasteful to me, and personally I would 
prefer automatic thread breaking, but unless there's widespread 
popular support for that I won't push too hard for it. Perhaps 
placing a patch on kmail.kde.org and closing the bug would be an 
acceptable compromise.

Don.

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]