[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Patches for kmail/kmailcvt to allow compilation on FreeBSD 4.x
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2002-12-30 23:39:48
[Download RAW message or body]

On Monday 30 December 2002 22:10, Andy Fawcett wrote:
> After some discussion with Lauri, who had a problem where PATH_MAX
> could not be found while building kmail and kmailcvt from HEAD, I've
> put together the following patches which solve the problem for her.
> I've also tested them on FreeBSD 5.0 and Linux 2.4.x where they apply
> and build okay.
>
> The core of the patch is to include <sys/param.h> if it is available,
> as I noted that on the three platforms I could build on, this file
> includes the necessary header with the definition of PATH_MAX. By
> including this one conditionally, it should not break things
> anywhere, and it saves having conditional compilation dependent on
> the build OS.
>
> Please review and commit them if they do not cause further problems.

Well, as KDE_3_1_BRANCH seems to compile on FreeBSD (at least I didn't 
hear about any problems) while HEAD doesn't, why not simply readd the
#include <limits.h>
to kmfoldermaildir.cpp which apparently someone removed because he 
thought this header wouldn't be needed.

Please try if re-including <limits.h> fixes the compilation problem.

Regards,
Ingo


[Attachment #3 (application/pgp-signature)]
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]