[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Fix bug 48307
From:       Michael =?iso-8859-1?q?H=E4ckel?= <haeckel () kde ! org>
Date:       2002-10-29 20:17:18
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 27 October 2002 22:09, Carsten Burghardt wrote:
>
> OK, here we go, this should work. At lot of stuff to keep the folder from
> closing...

What shall I do with this patch now?

I also wonder if this really can't be done easier.

Your code doesn't seem to handle the case that a job get cancelled or am I 
missing something? This results in still open folders then.

What about telling the KMImapJob to close the folder itself when it's done 
instead of emitting a signal which tells a different function to close the 
folder? That should make thinks much easier and also allow to fix the above 
mentioned problem.

Couldn't this complicated code:
+      if (mClose) 
+      {
+        // close the folder
+        emit messageStored((*it).msgList.last(), true);
+      } else {
+        emit messageStored((*it).msgList.last(), false);
+      }

be simplified a bit:
+ emit messageStored((*it).msgList.last(), mClose);

Actually somewhen ago switching to a different folder simply killed all jobs 
for the current folder which also prevented this kind of crashes, but this 
function appears to be dead code now.

Regards,
Michael Häckel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE9vuzOe9KEPyN2R8URApV1AJ4/VlSwzkyRfaf4dFcfpP1CjXbLXACdGXcE
xRl1WhusFTd5HUExJ/M8xG0=
=1IdX
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]