[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] increase moveMsg performance
From:       "Carsten Burghardt" <cb () magic-shop ! de>
Date:       2002-08-27 7:46:55
[Download RAW message or body]


 Don Sanders wrote:
> Hi,
>
> I think it's a nice feature, but I do think it's a feature.
> (Perhaps  I'm biased because this patch will create conflicts I'll
> have to
> resolve).

And I'm biased because I'm using imap every day and this patch
definitely increases the performance.

> It would be nice if we could avoid adding even more
> protocol() == "imap" checks especially in KMFolder, that's
> obviously  pretty poor design. In my commands diff I have managed
> to remove a  number of these checks in kmheaders, but not all of
> them.
>
> The right thing to do is improve KMFolder and related
> abstractions.  But perhaps it's best to improve KMFolder etc after
> your patch is  applied.

I do agree that this is poor design but as I currently don't have
your commands I don't have a choice. I think we should apply it and
I'll gladly port this for 3.2 ;-)

> Don.
>
> On Monday 26 August 2002 16:26, Carsten Burghardt wrote:
>> On Sunday 25 August 2002 19:58, Carsten Burghardt wrote:
>> > Hi,
>> >
>> > at the moment the destination folder of an imap moveMsg is
>> > downloaded (getFolder) after each operation. This is too
>> > time-consuming. The attached patch does 2 things:
>> > - just increment the cached total-count for the total-column
>> > - the destination-folder is not opened/closed for this because
>> the message is only added on the server. This improves
>> > performance and is needed because otherwise the cached
>> > total-count would be overwritten with an old value.
>> >
>> > By the way: this is no feature ;-)
>>
>> I forgot the case of one message, see the attached version.
>
> _______________________________________________
> KMail Developers mailing list
> kmail@mail.kde.org
> http://mail.kde.org/mailman/listinfo/kmail


-- 
Carsten Burghardt


_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]