[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] increase moveMsg performance
From:       Don Sanders <sanders () kde ! org>
Date:       2002-08-27 7:26:56
[Download RAW message or body]

Hi,

I think it's a nice feature, but I do think it's a feature. (Perhaps 
I'm biased because this patch will create conflicts I'll have to 
resolve).

It would be nice if we could avoid adding even more 
protocol() == "imap" checks especially in KMFolder, that's obviously 
pretty poor design. In my commands diff I have managed to remove a 
number of these checks in kmheaders, but not all of them.

The right thing to do is improve KMFolder and related abstractions. 
But perhaps it's best to improve KMFolder etc after your patch is 
applied.

Don.

On Monday 26 August 2002 16:26, Carsten Burghardt wrote:
> On Sunday 25 August 2002 19:58, Carsten Burghardt wrote:
> > Hi,
> >
> > at the moment the destination folder of an imap moveMsg is
> > downloaded (getFolder) after each operation. This is too
> > time-consuming. The attached patch does 2 things:
> > - just increment the cached total-count for the total-column
> > - the destination-folder is not opened/closed for this because
> > the message is only added on the server. This improves
> > performance and is needed because otherwise the cached
> > total-count would be overwritten with an old value.
> >
> > By the way: this is no feature ;-)
>
> I forgot the case of one message, see the attached version.

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]