[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: system tray notification patches updated for 3.1
From:       Ryan Breen <ryan () porivo ! com>
Date:       2002-06-24 12:33:53
[Download RAW message or body]


Thanks!

I had those features in the basic patch until the most recent revision.  I 
removed them to keep things as simple as possible and to remove dependencies 
on KMMainWin and KMFolderTree.

These features still exist in the combined and combined+popup patches, but 
those still have problems handling multiple KMMainWins.  The multiple window 
case raises the following ambiguities:

1) Which window should you jump to on systray click?
2) How can I safely get a reference to a KMMainWin from KMKernel?  KMKernel 
has the following code several places -- 
 KMMainWin *mWin = 0;
 KMainWindow *kmWin = 0;

  for (kmWin = KMainWindow::memberList->first(); kmWin;
    kmWin = KMainWindow::memberList->next())
      if (kmWin->isA("KMMainWin")) break;
  if (kmWin && kmWin->isA("KMMainWin")) {
    mWin = (KMMainWin *) kmWin;
    // use this mWin
  } 

so I assume that works and is safe.  I'm still worried about corner cases 
where the user picks a foldername from the systray popup menu, I grab a 
reference to that kmmainwin, but some other activity closes the kmmainwin 
before I use the reference (to jump to the window or to navigate through its 
foldertree).  Even if I preface every dereference of kmmainwin with a fresh 
getter call, there is still a tiny race condition, is there not?

If the answer to 1 is "we don't care" and the answer to 2 is "that corner case 
is small enough that we don't care" or (preferably) "here's a better way to 
do it", it'll be simple enough to merge those features back into the basic 
patch :-)

Ryan

On Monday 24 June 2002 03:03 am, Aaron J. Seigo wrote:
> hi ...
>
> after running kmail w/the new system tray patch for a while now it has
> really grown on me. some things that seem to be lacking right now:
>
>  o clicking on the system tray icon should take you to a kmail window
>  o the menu should perhaps show some information regarding what is waiting
> for you; at a minimum the number of new messages, perhaps even a list of
> the folders that have items in them (which when clicked would take you to
> that folder directly)
>
> it is quite nice otherwise =))

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]