[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Abstracting date handling.
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <ingo.kloecker () epost ! de>
Date:       2002-03-30 11:49:49
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 30 March 2002 12:36, Zack Rusin wrote:
>d) things that worry me:
> - kmfoldermaildir.cpp and kmfoldermbox.cpp look at the patch, I
> commented out those lines, because both those functions have
> something like:
> QString dateStr;
> (... few lines with no visible connection to dateStr ...)
> if ( !dateStr.isEmpty() )
>    message->setDate(dateStr);
> Unless I'm missing something here (it's 5am so I might be), these
> don't make any sense at all. I wanted to contact you before doing
> anything with those.

You are missing that dateStr is set a little bit further down in the 
while-loop. The if-branch which contains the message->setDate(dateStr); 
is only executed if a message has been read completely and in this case 
dateStr is set to the value of the Date: header of this message (unless 
the Date: header was missing).

So these lines must not be removed. But the following inconsistency 
should be removed:
In kmfoldermbox.cpp:
	  mi->setDate(dateStr);
In kmfoldermaildir.cpp:
      if (!dateStr.isEmpty())
        mi->setDate(dateStr);

Unfortunately I don't know which one is correct.

Regards,
Ingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8paZdGnR+RTDgudgRAlUNAKCY00tvzKBVH6V182hNv3E/ixJDHACg0dL5
IKv2a09hTf0a6sqod3jNErs=
=jcgE
-----END PGP SIGNATURE-----
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]