[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] KMail filters
From:       Michael =?iso-8859-1?q?H=E4ckel?= <haeckel () kde ! org>
Date:       2002-02-27 21:12:40
[Download RAW message or body]

On Monday 25 February 2002 22:56:22, Waldo Bastian wrote:
> The following patch preserves KMail's filter settings in case the folder
> happens to not exists for some reason. Filters involving non-existing
> folders are preserved but ignored

I think, this change lowers the usability for "normal" users that don't 
experiment with moving their ~/Mail around.

Currently, if I for example unsubscribe from a mailing list and am no longer 
interested in the mails, I just unsubscribe and delete the folder. With your 
change I would also have to look for stale filter rules.

I didn't test it, but does your read/write combobox also work, if two folders 
have to same name, but are subfolders of different top level folders?

Independant of your patch it crashes always on exit, after I try to filter 
to a non existing folder. At least, when I delete the folder with KMail while 
it is running and don't restart it before.

BTW: The problem, that the folder properties are also lost it still there with 
your patch.

I think, we better leave it as it is until we have a real solution.

> This would IMO improve the usability of KMail since it would reduce the
> steps necassery to create a filter+folder for a mailinglist.

Maybe it would also be enough, if it would be just part of the automatic 
filter creation.

> The following patch is for KDE 3.0. Please review.

BTW2: Regarding patches in general:

I'm the maintainer and posting patches for reviewal is good and should be 
done, but this doesn't absolutely mean, that I need to be the one who reviews 
them all.

About a year ago, this was fairly easy, if I didn't have much time, 
development of KMail simply was basically stopped. Now there are a lot more 
developers and things are quite different which is nice in general.

While bug reports usually can wait a week or two until I have time to 
fix the issue, it is probably not so nice, if patches have to wait long.

I consider at least Ingo, Marc and you also being able to review patches.
I'm definitely not looking at post-KDE-3.0 patches now, sorry.

I just started with my dissertation and have a fairly well organized work day 
now, at least as long there are things I can do. There will probably also be 
times where I can't do much but wait for example for some ordered things to 
arrive to be able to continue. During such periods I'll probably have more 
time during the week.
Therefore I have now unlike before really free week ends where I'm definitely 
not going to enter the university.

Regards,
Michael Häckel


_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]