[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] KMail filters
From:       Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date:       2002-02-27 19:49:39
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 25 February 2002 22:56, Waldo Bastian wrote:
> The following patch preserves KMail's filter settings in case the
> folder happens to not exists for some reason. Filters involving
> non-existing folders are preserved but ignored.
<snip>

1. I don't understand why you removed all the isEmpty() checks.
Didn't work reimplementing KMFilterAction::isEmpty() as { return false; 
} in KMFilterActionWithFolder and returning ErrorButGoOn from process() 
in the case of non-existent folders?
Without having it tested, I guess your patch leads to keeping of actions 
that are clearly empty, like:
[remove header] [""]

2. What good is it to have an editable KMFolderComboBox? I can see the 
benfit of displaying the folder ID in case the folder does not exist, 
but why should the user be able to edit it? IMHO, an extra button to 
the right of the folder combo that gives the user the kmfolderdia when 
clicked would be preferable. It could be done w/o i18n changes (the 
tooltip can be added later or possibly found elsewhere in Kmail).

I agree that creating folders from the filter dialog is nice. FWIF, the 
button could be bundled with KMFolderComboBox to provide a widget not 
unlike KURLRequester that could be used in the config dialog, too.

Marc

- -- 
Marc Mutz <mutz@kde.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8fThT3oWD+L2/6DgRArDAAKDwN+6rMwTsokZKQR7eQ7HiJ4XA/wCgwMmd
WaffYYniRFcvPN33k/rXDpQ=
=HWn2
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]