[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: KMMsgDict slowness
From:       Ronen Tzur <rtzur () shani ! net>
Date:       2002-01-02 19:03:01
[Download RAW message or body]

On Wednesday 02 January 2002 12:35, Michael Häckel wrote:
> On Thursday 03 January 2002 01:15, Ronen Tzur wrote:
> > Alright, then I will try to implement the final optimization, which would
> > be to have the reverse-array point directly to the corresponding entry in
> > the dictionary (instead of keeping the serial number for that message).
> >
> > But for KMMsgDict::getMsgSerNum() to still work in this situtation
> > requires four more bytes per dictionary element, to keep the serial
> > number. Is this ok?
>
> If this requires more memory, then I don't see, why we should do it.
>
> All what we get is a speed improvement, that would allow then maybe 12
> instead of 8 messages moved per second. This is still far away from what
> one would expect from a computer with a few hundred MHz.

I disagree.   When you changed the number of buckets to 199,999 you
made the lookup performed by dict->find(msn) faster, and just doing that
gave you a rate of 15 messages per second.   What I propose is to get rid
of the lookup entirely, so the result would be even better than 15.

In my opinion, paying extra four bytes per message for this isn't that costly.
Would you reconsider?

> > > However it now crashes always, when I try to store a message in the
> > > drafts folder.
> >
> > That doesn't happen here.   I tried both moving an existing message
> > into the drafts folder, and also "Save in Drafts Folder" from the
> > composer. Both work.
>
> See below. Maybe fp is not valid or why should rewind crash?

I'll check into it in a little while.

> Maybe also your patch was broken and a part was missing, at least "patch"
> complained and I had to apply the changes to kmmsglist.cpp manually.

I did edit it by hand, because I modified my kmmsglist.cpp to have more in it.
But kmmsglist.cpp shouldn't have an effect on the file pointer...

Anyway, I'll check it.
_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]