[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] fixes for new ConfigureDialog: PGP tab layout, transports problem
From:       Marc Mutz <Marc.Mutz () uni-bielefeld ! de>
Date:       2001-12-01 13:27:09
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 01 December 2001 12:02, Michael Häckel wrote:
> On Saturday 01 December 2001 13:23, Marc Mutz wrote:
> Already with just German and English it is wrong.

Fixed.
The profile list column widths are fixed, too.
And I changed a bit more of the kmfolder{dia,mgr}.cpp to reflect that 
maildir is now default. Please have a look at the hunks in those files.

> > This wasn't in the code before my changes, was it? The message box,
> > I mean...
>
> No, but before it simply reversed all settings instead of doing some
> strange things. At least I think so.

Not in any code I touched:
$ cvs co kdenetwork
$ cd kdenetwork/kmail
$ grep "threadMessagesOverride" *.cpp
kmheaders.cpp:  mNestedOverride = config->readBoolEntry( 
"threadMessagesOverride", false );
kmmainwin.cpp:  mFolderThreadPref = config->readBoolEntry( 
"threadMessagesOverride", false );
kmmainwin.cpp:  config->writeEntry( "threadMessagesOverride", 
mFolderThreadPref
);

> > I said in the changelog that I fixed the spelling of QuotedTex[123]
> > and that this would require a kconf_update entry. If someone could
> > tell me where to look to find kmail's....
>
> kdenetwork/kmail/kmail.upd
>
Added. Is this correct?
- --- kmail.upd   2001/09/27 12:05:40     1.3
+++ kmail.upd   2001/12/01 13:07:22
@@ -27,3 +27,10 @@ Group=Account 9
 RemoveKey=passwd
 Group=Account 10
 RemoveKey=passwd
+# Fix spelling of QuoutedText[123]
+Id=4
+File=kmailrc,kmailrc
+Group=Reader,Reader
+Key=QuoutedText1,QuotedText1
+Key=QuoutedText2,QuotedText2
+Key=QuoutedText3,QuotedText3

> > Besides: What's wrong with black as default quote color?
>
> That a nice feature is hidden by default.
>
OK. I use my colors now as default.

> > You haven't applied the patch that started this thread. At least
> > that was supposed to fix it. And it did for me.
>
> I think, I did. Also all patches applied plainly. Just the last one
> had an offset of one line. The PGP layout is also still broken here.

Then you haven't. The mentioned patch fixed exactly those two things ;-)

> Anyway a tar file and three incremental patches is already a lot of
> possible errors. Please post a complete patch or upload it somewhere,
> if the mailinglist really doesn't like it.

http://www.mathematik.uni-bielefeld.de/~mmutz/configuredialog-complete.diff.bz2 
(45K)
simplestringlisteditor.{h,cpp} has already been committed.

> > Sorry, I don't think I introduced that behaviour. I saw this 4x
>
> That is no reason for not fixing it. :-)

The reason is time. I hope you forgive me for fixing my own bugs and 
writing up this profile manager first. I want to get this done until 
tomorrow. Fixing other bugs can be postponed to after Sunday. ;-)

> Most of the bugs I fix were also not introduced by myself.

Might that be because you know the code best and are the maintainer? :-)

BTW: Would it be a good idea to implement the profile manager along the 
following lines?
1. look for kmailprofile-xyz-rc files using KStandardDirs
2. read the "name" and "desc" entries from each file
3. display the found profiles in the listview
4. on apply with profile tab visible (like before), each tab used the 
corresponding kmailprofile-xyz-rc file instead of plain kmailrc to read 
the entries?

Marc

- -- 
Ein Grundrecht auf Sicherheit steht bewusst nicht in der Verfassung.
  -- Sabine Leutheusser-Schnarrenberger (ehem. Bundesjustizministerin)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8CPe43oWD+L2/6DgRAhLkAJ976k2qJSrC6cwjC7DvtIfNC34aTwCgt42y
/M90JArle+vi3232oqBByOk=
=oEjr
-----END PGP SIGNATURE-----

_______________________________________________
kmail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]