[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] Bug #28908: login not possible (cookies ?)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-08-25 14:29:30
[Download RAW message or body]

On Saturday 25 August 2001 17:27, Martin Antenreiter wrote:
> 
> Hi!
> 
> Konqi doesn't send "domain" cookies back to the server
> (http://online.tu-graz.ac.at). The cookies look like (You can see it if
> you use the link "Anmelden"):
> 
>   Set-Cookie: TUG_LOGIN_ID=87789E213DBBB9633CD43FB1486E3C
>               ;domain=tu-graz.ac.at ;path=/tug_online/ ;secure
> 
> I think the kcookiejar save this cookie under the name "tu-graz.ac.at".
> Before a GET call kcookiejar search the cookie via ".tu-graz.ac.at" and
> can't find it.  Therefore you get the message "Your browser does not
> support cookies...". The little patch corrects this and shouldn't break
> anything. Hopefully!

I can't comment on whether it's correct or not, not knowing the code, but
I can nitpick the patch :)
'.' + ... is dangerous, I'm even surprised it compiles.
Better use lastCookie.mDomain.prepend( '.' );

>From your analysis, the patch sounds correct though. But Dawit or Waldo will 
be able to comment better :)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/ , http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

[prev in list] [next in list] [prev in thread] [next in thread]