[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    what's the return value of kjs-functions that appear to be void?
From:       Tobias Anton <anton () stud ! fbi ! fh-darmstadt ! de>
Date:       2001-07-27 21:06:14
[Download RAW message or body]

Hi,
for the following patch, we're not sure about the result of the function:

 @@ -1074,8 +1074,9 @@ Completion WindowFunc::tryExecute(const
    case Focus:
 -    result = Undefined();
 -    // TODO
 +    if (widget)
 +               widget->setActiveWindow();
 +    return Completion(Normal);
      break;

should it rather be Undefined()?
 +    result = Undefined();
and later:
  return Completion(ReturnValue, result);

What's the difference in the meaning of:
Completion(Normal);
and:
Completion(ReturnValue, Undefined());

If the first is the Case, it would need to be changed in manymany places in 
kjs_window and probably elsewhere.
Harri?

Regards,
Tobias

[prev in list] [next in list] [prev in thread] [next in thread]