[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: PCRE regexp patch.
From:       Michael Bedy <mjbedy () mediaone ! net>
Date:       2001-02-04 1:25:25
[Download RAW message or body]



On Sat, 3 Feb 2001, Stephan Kulow wrote:

> Harri Porten wrote:
> > 
> > Stephan Kulow wrote:
> > >
> > > Michael Bedy wrote:
> > > >
> > > >   This probably should not be checked in now because of the feature
> > > > freeze? Or is this (as a non-user visible patch) still cool to be checked
> > > > in?
> > 
> > Every patch become user visible once it breaks something ;) If you say
> > it works I'm fine with comitting as it's optional. The only issue I'm
> > not sure is the effect on binary packages. Wouldn't be nice if
> > uninformed packagers distribute RPMs that have a missing dependency.
> > Crash ?
> library dependencies are done automaticly. 
> > 
> > > The autoconf part looks ok, but don't add config.h to public headers. I don't
> > > know if regexp.h is public - so just in case. And if it's not public, drop the
> > > #ifdef HAVE_CONFIG_H
> > 
> > It's not public. Just an internal wrapper in case somebody wants to
> > replace the regexp lib one day :)
> > 
> > All in all, I think it's a very nice thing. The only aspect speaking for
> > post 2.1 is the additional library dependency.
> I see this as no reason. What bothers me more is that some users will have it
> and their konqueror behaves differently than for those without it. So we should
> either require it (and put a copy in kjs?) or not depend on it at all.
> 
  
   Well, it is easy (of course) to remove HAVE_CONFIG_H, will do so.

   libpcre seems to be a fairly common library. Lots of major programs
(i.e. php, python) use it. It should probably be stated loudly in the
README that it is required for even partway decent regex support in
Javascript. The packagers should probably told directly as well. That is
if we deside it is a good idea to check it in now.

   Should I commit it as it is - a compile time check?

     - Mike

[prev in list] [next in list] [prev in thread] [next in thread]