[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: "reload" in popup
From:       David Faure <david () mandrakesoft ! com>
Date:       2000-04-06 21:13:58
[Download RAW message or body]

On Thu, Apr 06, 2000 at 06:46:24PM +0200, Simon Hausmann wrote:
> 
> 
> On Thu, 6 Apr 2000, David Faure wrote:
> > * We should remove the new menu in this case... makes no sense (protocol doesn't support put/copy)
> > * Cut shouldn't be there (protocol doesn't support del)
> > * Preview in khtml shouldn't be there (forgot to check for current part !) :)
> > * Add whatever you want, it's not that big ;-) (Reload and reload frame especially)
> > * We could add stop and/or view source, like Netscape.
> > * Those two giants in the browser world :) feature "create shortcut" which
> > creates a link on the desktop. Sounds like something we should do ?
> 
> I 100% agree with all these points :-)
;-) Linked brains ?

> 1 and 2 were easy :-) (see attached patch (ok to commit?))
Almost. The first part seems to insert a separator even if
it didn't insert anything else ? See comments in the patch.

> I suppose 3) is a matter of defining X-KDE-BrowserView-Builtin for
> khtml_part?

Nope, see kde-cvs.

> I agree with 5 :-)
> 
> IMHO 6 would be a handy thing :)

Noted.

> > I'll have a look at what among this is feasible whenever I find some time :)
> > (2005?)
> 
> :-) fork()

strerror: no more resources available.... 

>      if ( S_ISDIR( mode ) ) // all URLs are directories
>      {
> -      // Add the "new" menu
> -      if ( m_pMenuNew )
> +      if ( sWriting )
>        {
> -        // As requested by KNewMenu :
> -        m_pMenuNew->slotCheckUpToDate();
> -        m_pMenuNew->setPopupFiles( m_lstPopupURLs );
> +        // Add the "new" menu
> +        if ( m_pMenuNew )
> +        {
> +          // As requested by KNewMenu :
> +          m_pMenuNew->slotCheckUpToDate();
> +          m_pMenuNew->setPopupFiles( m_lstPopupURLs );
> +  
> +  	  addAction( m_pMenuNew );
Don't use <tab> :-)

> +        }
>  
> -	addAction( m_pMenuNew );
> +        addSeparator();
This one will be added even if sWriting = false ?
Should above the '}'

> -      addSeparator();
> -
>        if ( currentDir ) {
>          addAction( "up" );
>  	addAction( "back" );
> @@ -211,7 +214,8 @@
>  
>      if ( sReading )
>      {
> -      addAction( "cut" );
> +      if ( sDeleting )
> +        addAction( "cut" );
>        addAction( "copy" );
>      }
Looks good.

Thanks !

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/
KDE, Making The Future of Computing Available Today
See http://www.kde.org/kde1-and-kde2.html for how to set up KDE 2

[prev in list] [next in list] [prev in thread] [next in thread]