[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: "reload" in popup
From:       Simon Hausmann <shaus () helios ! med ! Uni-Magdeburg ! DE>
Date:       2000-04-06 16:46:24
[Download RAW message or body]

On Thu, 6 Apr 2000, David Faure wrote:

> On Thu, Apr 06, 2000 at 06:16:19PM +0200, Simon Hausmann wrote:
> > 
> > 
> > On Thu, 6 Apr 2000, David Faure wrote:
> > 
> > > On Thu, Apr 06, 2000 at 01:19:45PM +0200, Simon Hausmann wrote:
> > > > 
> > > > 
> > > > On Thu, 6 Apr 2000, David Faure wrote:
> > > > 
> > > > > Hmm. So many things people want in this popup...
> > > > > Don't you think it's getting too big ?
> > > > 
> > > > Yes, that's a good point.
> > > > 
> > > > Well, the real reason why I'm asking is:
> > > > - Netscape and IE have it ;-)
> > > 
> > > Right - interesting, IE's is even bigger, but Netscape's is very small :)
> > > 
> > > We could perhaps remove other things, at least when showing HTML.
> > > 
> > > Let's compare :
> > > 
> > > Netscape has
> > > Back/Forward/Reload/Stop | View Source/View Info | Add Bookmark/Create Shortcut/Send Page
> > > 
> > > IE has
> > > Back/Forward | Save Background As/Set as Wallpaper/Copy background |
> > > Select All/Paste | Create Shortcut/Add To Favorites/View Source |
> > > Encoding submenu | Print/Refresh | Properties
> > > 
> > > Wow ;-)
> > > 
> > > Now you can compare with what we have in konq (in html mode),
> > > or I'll do it at home... This could lead to some interesting ideas
> > > on how to remove / add / implement :-) 
> > 
> > Ok, for an html document in Konqueror we have:
> > 
> > New (with submenu) | Up/Back/Forward | New View | Cut | Copy | Add To
> > Bookmarks | Preview in khtml ;-) | Netscape (as service) | Edit File Type
> > | Properties
> > 
> > Ideas? :-)
> 
> * We should remove the new menu in this case... makes no sense (protocol doesn't support put/copy)
> * Cut shouldn't be there (protocol doesn't support del)
> * Preview in khtml shouldn't be there (forgot to check for current part !) :)
> * Add whatever you want, it's not that big ;-) (Reload and reload frame especially)
> * We could add stop and/or view source, like Netscape.
> * Those two giants in the browser world :) feature "create shortcut" which
> creates a link on the desktop. Sounds like something we should do ?

I 100% agree with all these points :-)

1 and 2 were easy :-) (see attached patch (ok to commit?))

I suppose 3) is a matter of defining X-KDE-BrowserView-Builtin for
khtml_part?

I agree with 5 :-)

IMHO 6 would be a handy thing :)

> I'll have a look at what among this is feasible whenever I find some time :)
> (2005?)

:-) fork()


Bye,
 Simon

["p.txt" (TEXT/PLAIN)]

Index: konqpopupmenu.cc
===================================================================
RCS file: /home/kde/kdebase/libkonq/konqpopupmenu.cc,v
retrieving revision 1.32
diff -u -r1.32 konqpopupmenu.cc
--- konqpopupmenu.cc	2000/04/04 22:24:42	1.32
+++ konqpopupmenu.cc	2000/04/06 16:41:20
@@ -174,18 +174,21 @@
   {
     if ( S_ISDIR( mode ) ) // all URLs are directories
     {
-      // Add the "new" menu
-      if ( m_pMenuNew )
+      if ( sWriting )
       {
-        // As requested by KNewMenu :
-        m_pMenuNew->slotCheckUpToDate();
-        m_pMenuNew->setPopupFiles( m_lstPopupURLs );
+        // Add the "new" menu
+        if ( m_pMenuNew )
+        {
+          // As requested by KNewMenu :
+          m_pMenuNew->slotCheckUpToDate();
+          m_pMenuNew->setPopupFiles( m_lstPopupURLs );
+  
+  	  addAction( m_pMenuNew );
+        }
 
-	addAction( m_pMenuNew );
+        addSeparator();
       }
 
-      addSeparator();
-
       if ( currentDir ) {
         addAction( "up" );
 	addAction( "back" );
@@ -211,7 +214,8 @@
 
     if ( sReading )
     {
-      addAction( "cut" );
+      if ( sDeleting )
+        addAction( "cut" );
       addAction( "copy" );
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]